Deployment to crates.io #610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add .so and .a compilations artifacts for the library.
Add these fields in the Cargo.toml file, they will be published on crates.io
jpraynaud
force-pushed
the
ensemble/588-deployment-crates.io
branch
from
7a7b364 to
9d782b2
Compare
Replace them with 'Stm' for clarity.
jpraynaud
force-pushed
the
ensemble/588-deployment-crates.io
branch
9 times, most recently
from
6928392 to
721c55a
Compare
jpraynaud
requested review from
Alenar,
iquerejeta,
ghubertpalo and
curiecrypt
jpraynaud
force-pushed
the
ensemble/588-deployment-crates.io
branch
from
721c55a to
66d583b
Compare
iquerejeta
approved these changes
Nov 24, 2022
Comment on lines
+101
to
+105
| - name: Cargo publish dry run | ||
| uses: actions-rs/cargo@v1 | ||
| with: | ||
| command: publish | ||
| args: -p mithril-stm --dry-run |
There was a problem hiding this comment.
Why are we running two times with --dry-run? With and without the token?
There was a problem hiding this comment.
We will remove the second --dry-run once we have a working CRATES_IO_API_TOKEN (we keep the dry-run to prevent the workflow from failing at this last step) 👍
Comment on lines
-162
to
-166
| # ToDo list once we go public | ||
| - [ ] Upload mithril-core to crates.io | ||
| - [ ] Ensure that the badges are working | ||
| - [ ] Update links for crates and docs | ||
| - [ ] Error handling |
There was a problem hiding this comment.
Thanks for removing this 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR implements the deployment of
mithril-stmlibrary tocrates.io:mithril-stmcrates.iopackaging and publishing in the Release workflowPre-submit checklist
Authors
@Alenar
@jpraynaud
Issue(s)
Closes #588 / Relates to #500